Skip to content

refactor(linux): remove leftovers from portalgrab -> pipewire split#5039

Merged
ReenigneArcher merged 2 commits intoLizardByte:masterfrom
psyke83:portalgrab_leftovers
Apr 23, 2026
Merged

refactor(linux): remove leftovers from portalgrab -> pipewire split#5039
ReenigneArcher merged 2 commits intoLizardByte:masterfrom
psyke83:portalgrab_leftovers

Conversation

@psyke83
Copy link
Copy Markdown
Contributor

@psyke83 psyke83 commented Apr 21, 2026

Description

Duplicate removal only - no functional changes.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@Kishi85
Copy link
Copy Markdown
Contributor

Kishi85 commented Apr 21, 2026

Thanks for cleaning this up some more. Would you mind checking the log messages in pipewire.cpp as well? I likely have missed some textual references to portal_t there.

@psyke83
Copy link
Copy Markdown
Contributor Author

psyke83 commented Apr 21, 2026 •
edited
Loading

I cut out a lot of headers that I assume were taken from the kmsgrab template; most of the standard includes are already covered in platform/common.h and some other places such as thread_safe.h, and portalgrab doesn't really need any unique headers that aren't already used by pipewire.cpp.

@Kishi85 I've covered the two log references. Anything else you'd like changed? There are a few references to portal in pipewire's annotated comments that were copied over, but that doesn't seem too important to change.

@Kishi85
Copy link
Copy Markdown
Contributor

Kishi85 commented Apr 22, 2026

Thanks for the change. That should be all on my end.

@psyke83 psyke83 marked this pull request as ready for review April 22, 2026 10:59
psyke83 added 2 commits April 22, 2026 17:22
@psyke83 @ReenigneArcher
refactor(linux): remove leftovers from portalgrab -> pipewire refactor
26d565a 
Duplicate removal only - no functional changes.
@psyke83 @ReenigneArcher
refactor(linux): additional cleanups
266a10c 
* Remove headers that are already part of pipewire.cpp
* Eliminate duplicate headers from pipewire.cpp
* Rename portal_t -> pipewire_t in pipewire logs
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 22, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@1ba440e). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/linux/pipewire.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5039   +/-   ##
=========================================
  Coverage          ?   18.15%           
=========================================
  Files             ?      109           
  Lines             ?    23576           
  Branches          ?    10402           
=========================================
  Hits              ?     4280           
  Misses            ?    16864           
  Partials          ?     2432
Flag Coverage Δ
Archlinux 11.53% <0.00%> (?)
FreeBSD-14.3-amd64 13.75% <0.00%> (?)
Homebrew-ubuntu-22.04 13.90% <0.00%> (?)
Linux-AppImage 12.48% <0.00%> (?)
Windows-AMD64 14.86% <ø> (?)
Windows-ARM64 13.25% <ø> (?)
macOS-arm64 19.07% <ø> (?)
macOS-x86_64 18.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/portalgrab.cpp 17.84% <ø> (ø)
src/platform/linux/pipewire.cpp 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba440e...266a10c. Read the comment docs.

@ReenigneArcher ReenigneArcher merged commit c4b3065 into LizardByte:master Apr 23, 2026
72 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Bundle Report

Bundle size has no change ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@psyke83 @Kishi85 @ReenigneArcher